-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rewrite parsing, evaluation, and serialization #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rewrite effectively the entire compiler in order to implement all missing features. This includes
@supports
conditions@at-root
conditions@import
conditions and querieskeywords
NaN
,Infinity
, and-Infinity
@forward
This PR also implements new features that
dart-sass
has added through the course of this year, includingcalculation
value type and simplification. that is, something likecalc(1 + 1)
will now be simplified to the literal number2
$epsilon
,$max-safe-integer
,$min-safe-integer
,$max-number
,$min-number
meta.calc-name
andmeta.calc-args
list.slash
Miscellaneous changes and improvements:
num-rational
,num-traits
,num-bigint
, andbeef
bootstrap
now compiles 3-4x faster on my machineAs a result of this PR, we are now failing 886/6905 spec tests. ~20% of these failures come from
@use
,@forward
, and the module system. ~50% of these failures come from the builtin functions. It appears a large number of the current failures are either purely cosmetic (e.g. the whitespace of inline/* */
comments) or related to error messages.Work remaining on this PR before merging:
meta.load-css
Closes #52
Closes #31