-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add workflow to automatically build WASM files #92
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
needs to be merged asap
Awesome, thank you for opening this PR. This is something I've been thinking about setting up for a while. I'll take a look sometime this week. |
CI seems to be failing due to a malformed cargo.toml. Ideally this action wouldn't run on every commit pushed to master, but rather on every release/tag created. |
I am not sure what caused this. I have only appened my stuff to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@connorskees when do you want this github action to run? on every release? or tag push? and how are your tags looking? v*.*.*
?
@Katze719 Ideally every tag, as so far I haven't done any releases. You can see the tags in https://github.com/connorskees/grass/tags, I think I started with a v prefix but eventually dropped it. |
The reason why we ask this is because for the workflow to trigger you need to specify a pattern. Example: |
Co-authored-by: Katze719 <38188106+Katze719@users.noreply.github.com>
@connorskees The workflow sould now trigger on every TAG pushed. |
Hey @connorskees I don't want to be intrusive, but can this pull-request be merged? Or is something still missing? |
Hi @Katze719, CI is failing. I think you'd need to change which Cargo.toml file you edit. You probably want the one inside |
@connorskees Everything thould be fixed now. 👍 |
I have commented out the |
@connorskees I have updated everything. Should work now. |
@connorskees Is there still something missing? Or can this be merged? |
Looks good to me. Thanks again for your work on this! |
np 👍 |
Hey I recently opened this issue #91. I personally don't have much experience with WebAssembly or Rust. However, I have tried to create an automated workflow to create WASM bindings for this project on release.
This is the first time I contribute to such a large project.