Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Update interactive map preview #176

Merged
merged 2 commits into from
Oct 20, 2023
Merged

ENH: Update interactive map preview #176

merged 2 commits into from
Oct 20, 2023

Conversation

brendan-ward
Copy link
Collaborator

@brendan-ward brendan-ward commented Oct 19, 2023

Resolves #65 by replacing Leaflet and Mapbox GL JS with Maplibre GL; interative map controls used in the Leaflet version are no longer available.

Resolves #147 by removing the built-in basemap. To our knowledge, there are no freely-available map tiles that do not have usage limits, authentication requirements, or licensing restrictions that can be used a built-in option.

mbtileserver now supports bring-your-own basemap via the --basemap-style-url or --basemap-tiles-url options.

@coveralls
Copy link

coveralls commented Oct 19, 2023

Coverage Status

coverage: 8.103% (-0.02%) from 8.119% when pulling 9d8c587 on rework_preview into 88ffb6c on main.

@brendan-ward brendan-ward marked this pull request as ready for review October 20, 2023 00:15
@brendan-ward brendan-ward merged commit c67091b into main Oct 20, 2023
19 of 20 checks passed
@brendan-ward brendan-ward deleted the rework_preview branch October 20, 2023 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider alternative basemap tile providers Drop Leaflet, move everything to Mapbox GL
2 participants