Fixes for graceful reload #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brendan-ward
approved these changes
Jul 1, 2019
There was a problem hiding this comment.
One typo to fix and otherwise ready to merge.
Thanks @nikmolnar, this was the direction I was hoping we would go in for this feature.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes two issues with the newly-introduced graceful reload functionality.
The first fix addresses #71 by making reload an optional feature, disabled by default. The functionality can be enabled by passing the
--enable-reloadflag at startup.The second fix addresses a problem that would cause the primary process to exit when near-concurrent reload requests were received (the newly forked process would receive a
HUPsignal before the handler was registered, which resulted in the default handler being invoked and exiting the process; this in turn prompted the parent process to exit as well).The fix for this adds a .5s wait between reloads, to give the new child process time to start and register its
HUPhandler.