This repository has been archived by the owner on Jan 29, 2024. It is now read-only.
FM-162: FIL actor feature #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adlrocha
reviewed
Jul 31, 2023
adlrocha
suggested changes
Jul 31, 2023
There was a problem hiding this comment.
This approach LGTM for now. However, as we are deprecating the native actors for now, I think we should take all common types for IPC to an independent repo (or maybe a crate inside IPC-agent/Fendermint?). That way we could archive this repo (if needed). @aakoshh, @cryptoAtwill, WDYT?
Also, @aakoshh, it seems adding the feature in one of the methods break the actor.
aakoshh
force-pushed
the
fm-162-fil-actor-feature
branch
from
9fd553a
to
df0d3d8
Compare
|
I don't have an opinion on the matter because I never used these; I just need the |
adlrocha
approved these changes
Jul 31, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
fil-actorfeature so that we can depend onipc-sdkwithout having to add a dependency on thefvm-utils/fil-actor-runtimecrate, which is a modified copy of the builtin-actorsRuntime, which was generally not needed so far in a host application like Fendermint or the FVM.Tests
It still compiles, and disabling the feature only removes some methods that rely on the
Runtime, which I do not intend to use. I added a step to the CI build to check theipc-sdkwith no default features, to catch any potential compilation bugs.Issues
Not at the moment.