Skip to content
This repository has been archived by the owner on Jan 29, 2024. It is now read-only.

Migrate cross #130

Merged
merged 4 commits into from
Aug 10, 2023
Merged

Migrate cross #130

merged 4 commits into from
Aug 10, 2023

Conversation

cryptoAtwill
Copy link
Collaborator

Motivation

Cross network related types and utility functions will be used by not just gateway actor, but also ipc-agent and fendermint. Migrating to sdk helps fendermint and downstream crates from importing large chunks of irrelevant code in gateway.

Solution

Just copy paste and update the dependency paths...

Copy link
Contributor

@adlrocha adlrocha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just before you merge a few things:

  • Let's fix CI, it is not happy.
  • Let's ugrade the dependency in the ipc-agent (and potentially fendermint) to point to the new type paths.
    Let me know if you need help with any of these.

@adlrocha adlrocha merged commit fccc94b into main Aug 10, 2023
3 checks passed
@adlrocha adlrocha deleted the migrate-cross branch August 10, 2023 08:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants