Skip to content

Commit

Permalink
test websocat by bypassing jupyter-server-proxy
Browse files Browse the repository at this point in the history
  • Loading branch information
consideRatio committed Mar 10, 2024
1 parent caea605 commit 660185d
Show file tree
Hide file tree
Showing 2 changed files with 16 additions and 0 deletions.
15 changes: 15 additions & 0 deletions .github/workflows/test.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,21 @@ jobs:
}
echo "::endgroup::"
echo "::group::Installing websocat in container"
docker exec --user root $container_id bash -c '
wget -q https://github.com/vi/websocat/releases/download/v1.12.0/websocat.x86_64-unknown-linux-musl \
-O /usr/local/bin/websocat
chmod +x /usr/local/bin/websocat
websocat --help=long
'
echo "::endgroup::"
echo "::group::Testing /desktop-websockify/ to return a vncserver typical response from within the container"
docker exec $container_id bash -c '
websocat -vv --no-async-stdio --binary --one-message --exit-on-eof 'ws://localhost:5901'
'
echo "::endgroup::"
echo "::group::jupyter_server logs"
docker logs $container_id
echo "::endgroup::"
Expand Down
1 change: 1 addition & 0 deletions jupyter_remote_desktop_proxy/setup_websockify.py
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,7 @@ def setup_websockify():
+ websockify_args
+ ['--', '/bin/sh', '-c', f'cd {os.getcwd()} && {vnc_command}'],
'timeout': 30,
'port': 5901,
'new_browser_window': True,
# We want the launcher entry to point to /desktop/, not to /desktop-websockify/
# /desktop/ is the user facing URL, while /desktop-websockify/ now *only* serves
Expand Down

0 comments on commit 660185d

Please sign in to comment.