Skip to content

Commit

Permalink
verify vncserver works by itself without websockify
Browse files Browse the repository at this point in the history
  • Loading branch information
consideRatio committed Mar 10, 2024
1 parent 4ef52b9 commit 6c73a3d
Showing 1 changed file with 18 additions and 13 deletions.
31 changes: 18 additions & 13 deletions .github/workflows/test.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,24 @@ jobs:
# to this, we fallback to use the errorcode of vncsrever -list.
docker run jupyter-remote-desktop-proxy bash -c "vncserver -help || vncserver -list > /dev/null"
- name: Run vncserver test without this project's logic
run: |
container_id=$(docker run -d --security-opt seccomp=unconfined jupyter-remote-desktop-proxy vncserver -xstartup /opt/install/jupyter_remote_desktop_proxy/share/xstartup -verbose -localhost -fg -geometry 1680x1050 -SecurityTypes None)
sleep 3
echo "::group::Installing netcat in container"
docker exec --user root $container_id bash -c '
apt update
apt install -y netcat
'
echo "::endgroup::"
echo "::group::Testing vncserver with netcat in container"
docker exec $container_id bash -c '
nc -w 1 localhost 5901 | grep RFB
'
echo "::endgroup::"
- name: Run basic tests and print logs
run: |
container_id=$(docker run -d -p 8888:8888 --security-opt seccomp=unconfined -e JUPYTER_TOKEN=secret jupyter-remote-desktop-proxy)
Expand Down Expand Up @@ -85,19 +103,6 @@ jobs:
'
echo "::endgroup::"
echo "::group::Installing netcat in container"
docker exec --user root $container_id bash -c '
apt update
apt install -y netcat
'
echo "::endgroup::"
echo "::group::Testing vncserver directly to return typical response from within the container"
docker exec $container_id bash -c '
nc -w 1 localhost 5901
'
echo "::endgroup::"
echo "::group::jupyter_server logs"
docker logs $container_id
echo "::endgroup::"
Expand Down

0 comments on commit 6c73a3d

Please sign in to comment.