Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite several prompts to take IntoIterator<Item: ToString> instead of &[T] #223

Closed
wants to merge 3 commits into from
Closed

Rewrite several prompts to take IntoIterator<Item: ToString> instead of &[T] #223

wants to merge 3 commits into from

Commits on Oct 22, 2022

  1. Rewrite several prompts to take IntoIterator<Item: ToString> instea… 

    …d of `&[T]`

This allows for much more flexibility when generating prompts. The user can pass in, for example, the output of a `.map` without having to collect it into a vector and provide a slice.
Since all these functions do is run a simple for loop over the input, it's an easy change to make. Existing code should continue to work, as &[T] implements IntoIterator<Item: T> by default.
    @waterlubber
    waterlubber committed Oct 22, 2022
    Configuration menu
    Copy the full SHA
    0f7f6b8 View commit details
    Browse the repository at this point in the history

  2. Reorder some where clauses and remove unnecessary path qualifications.

    @waterlubber
    waterlubber committed Oct 22, 2022
    Configuration menu
    Copy the full SHA
    54181b0 View commit details
    Browse the repository at this point in the history

  3. Reorder IntoIterator and ToString on where clauses again 

    By mistake I reordered every clause except the required one. This should fix that.
    @waterlubber
    waterlubber committed Oct 22, 2022
    Configuration menu
    Copy the full SHA
    2e280e6 View commit details
    Browse the repository at this point in the history