Shrink ProgressDrawTarget size #277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Size went down from 112 to 96 bytes
Only the amount of progress lines (total lines - orphan lines) was ever used from `last_state`. Size went down from 96 to 64 bytes
djc
reviewed
Apr 17, 2021
| || rate.is_none() | ||
| || last_draw.is_none() | ||
| || last_draw.unwrap().elapsed() > rate.unwrap() | ||
| || rate == Duration::from_secs(0) |
There was a problem hiding this comment.
I honestly don't like this use of a sentinel value. The benefit of saving 8 bytes doesn't really seem worth it to me.
There was a problem hiding this comment.
|| rate == Duration::from_secs(0) could be removed without affecting behavior (leaving just forced || finished || elapsed > rate), and there is some precedent for this kind of usage of duration, see rust-lang/rust#73544, and rust-lang/rust#84084 which stabilizes Duration::is_zero. However, I'm fine with reverting this part of the PR if that's not convincing
|
Okay, I will merge this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.