Skip to content
This repository has been archived by the owner on Mar 6, 2020. It is now read-only.

gb test does not work with main directory in src #375

Closed
gobwas opened this issue Sep 16, 2015 · 2 comments
Closed

gb test does not work with main directory in src #375

gobwas opened this issue Sep 16, 2015 · 2 comments

Comments

@gobwas
Copy link

gobwas commented Sep 16, 2015

If i have some directory tree like this:

├── src
│   ├── some_package
│   └── main
└── vendor
    └── src

running command gb test all throwing:

/usr/local/go/pkg/tool/darwin_amd64/link: cannot create /var/folders/g2/xmqjypqx3wn6h3nvq4yw9vr00000gp/T/gb539820733/main/_test/main: open /var/folders/g2/xmqjypqx3wn6h3nvq4yw9vr00000gp/T/gb539820733/main/_test/main: is a directory
@davecheney
Copy link
Contributor

Sorry about that. I've found the bug and a fix is being proposed now.

On Thu, Sep 17, 2015 at 1:01 AM, Sergey Kamardin notifications@github.com
wrote:

If i have some tree like this:

├── src
│ ├── some_package
│ └── main
└── vendor
└── src

running command gb test all throwing:

/usr/local/go/pkg/tool/darwin_amd64/link: cannot create /var/folders/g2/xmqjypqx3wn6h3nvq4yw9vr00000gp/T/gb539820733/main/_test/main: open /var/folders/g2/xmqjypqx3wn6h3nvq4yw9vr00000gp/T/gb539820733/main/_test/main: is a directory


Reply to this email directly or view it on GitHub
#375.

davecheney added a commit that referenced this issue Sep 17, 2015
Fixes #375

The test for Package.isMain had a loophole where a main package,
being built as a test would be linked.

- [ ] Add unit test for Package.isMain
davecheney added a commit that referenced this issue Sep 17, 2015
Fixes #375

The test for Package.isMain had a loophole where a main package,
being built as a test would be linked.

- [ ] Add unit test for Package.isMain
@gobwas
Copy link
Author

gobwas commented Sep 17, 2015

Thanks! 🍻

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants