This repository has been archived by the owner on Mar 6, 2020. It is now read-only.
Refactor logging #363
Merged
Refactor logging #363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduce new package gb/log. Perhaps one day this can be outsourced to a 3rd party.
Remove log.Errorf, it was only used in one place.
Remove log.Warnf, it was not used.
|
/cc @PSG-luna, this will be part of the 0.1.2 release next week. Please test with gb-appengine |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor logging
log. Hopefully one day in the future this can be outsourced.Debugf,InfofandFataf.Verboseenables debug level,Quietsilences info level, that's all there is too it. Errors, if not fatal should be handled and printed at info level -- they were not fatal after all.