This repository has been archived by the owner on Mar 6, 2020. It is now read-only.
vendor: allow ~ in import path #535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
~ is an allowed character in the import path, and it's used in the wild for user repositories
|
This looks ok, but I'd like to add a test, preferably in vendor/repo_test.go (from memory) to check that this works. Do you have a url that has a ~ in it that I can add as a test case ? |
|
Makes sense, but sadly I don't have a valid public one. |
|
That's ok. We'll just have to live with it if I break it in the future. |
davecheney
added a commit
that referenced
this pull request
Jan 9, 2016
vendor: allow ~ in import path
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
~ is an allowed character in the import path, and it's used in the wild for user repositories