Run compiler from the project directory #652
Conversation
|
The failure appears to be unrelated to my change. |
|
I'd love some feedback on this. |
|
Hello, I've fixed the build for the testing/testmain changes in Go 1.8, #657. Please rebase your change and push again. Sorry for the delay, I've recently changed jobs. Thanks Dave |
|
Sorry I haven't responded to this yet. Given the history of trying to fix On Sat, Nov 5, 2016 at 6:32 AM, Scott S. McCoy notifications@github.com
|
In an attempt to solve issue constabulary#406, run the compiler instead of from the package directory from the root of the project. Make all paths passed to the compiler relative to the project root. This appears to work, and the tests still pass; but it corrects the output of compiler errors and they now appear with filenames relative to the `GB_PROJECT_DIR`.
|
@davecheney I am relatively certain this isn't solving for all use-cases, but we have been using in our project (under my fork of this project) since this PR was opened and, within the usecase of our project, it solves the problem for go sources without side-effect. I think that a partial solution is probably better than no solution, since the behaviour of gb WRT compiler errors is a huge issue for adoption. We have the need to start adding assembler to our project build, and I will ensure that similar support is added for the assembler at that time. |
In an attempt to solve issue #406, run the compiler instead of from
the package directory from the root of the project. Make all paths
passed to the compiler relative to the project root.
This appears to work, and the tests still pass; but it corrects the
output of compiler errors and they now appear with filenames relative
to the
GB_PROJECT_DIR.