This repository has been archived by the owner on Mar 6, 2020. It is now read-only.
Remove filepath.Rel code from gc helper. #693
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GoFiles in gb come in two kinds. 1. relative to pkg.Dir 2. absolute In this case the work to absify then relify the path is a noop, which is further proven by removing it.
Codecov Report
@@ Coverage Diff @@
## master #693 +/- ##
==========================================
- Coverage 53.39% 53.32% -0.08%
==========================================
Files 40 40
Lines 3045 3036 -9
==========================================
- Hits 1626 1619 -7
+ Misses 1242 1241 -1
+ Partials 177 176 -1
Continue to review full report at Codecov.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GoFiles in gb come in two kinds.
In this case the work to absify then relify the path is a noop, which is
further proven by removing it.