-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
show a message if ENABLE_STUDY_FULL=(1/True/true) in process environment #6
Conversation
Deploy heroku with this variable set to disable new signups but not revocation+verification endpoints Some of the text still needs to be edited/audited, nonpublic Google Docs URL in it which I can also include easily enough when Maggie can provide it.
@moates @ginnyfahs i expect this to be pretty straightforward to review; to test it you can add ENABLE_STUDY_FULL to docker-compose.yml i can pretty quickly add a FAQ page given a doc before we land this and update the URL |
Thank you! I have time with Legal this week for final approval of the FAQ, at which point we can add it as a new page in the app to avoid the google docs link. Will let you know when that's ready. So appreciate the help here! |
Cleared the nit; i'll let this marinate until copy is approved and we can merge it all in one go. |
When I tried to Docker build this, I ran into a syntax error. Not sure if I somehow have a stricter syntax checker enabled?
It's been a hot minute since I wrote any javascript, so idk if this is the kosher approach, but I was able to build by adding the async keyword to studyFullCheck's callback function in member.js
|
add URL when it's ready
no, i don't think it's your or your environment's fault, it looks like it's mine :) i apparently don't understand all this async/await stuff, not sure why I thought I could push it like this! |
I validated this in-browser that it works, but i gotta say I don't really understand the async/await stuff in JS still :|
checks for any form of TruE TrUe etc, and is probably more legible this way even if it's a bit more repetetetitive
@rrix I added views/faq.mustache with the approved copy and markup. I started to add the routing logic myself but got a little confused about where to best handle that so it wouldn't get caught in study-full, so I'll leave that to you, or ask you for a pointer. |
thanks for pushing the copy, i added |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Built this locally, checked out the FAQ, tested external links! Thank you!
Deploy heroku with this variable set in the application configuration to disable new signups but not
revocation+verification endpoints
Some of the text still needs to be edited/audited, nonpublic Google
Docs URL in it which I can also include easily enough when Maggie can
provide it.
not a big fan of the massive changes in the diff , but that'll happen when you have to add new branches to code... none of the logic is really changed except for the escape hatch.