Skip to content

Commit

Permalink
Modify wording based on comments on July 25th
Browse files Browse the repository at this point in the history
  • Loading branch information
sunnylovestiramisu committed Jul 31, 2023
1 parent 6eaead6 commit 3e57adf
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion csi.proto
Original file line number Diff line number Diff line change
Expand Up @@ -385,7 +385,7 @@ message CreateVolumeRequest {

// Plugin specific parameters to apply, passed in as opaque
// key-value pairs. This field is OPTIONAL. The Plugin is
// responsible for parsing and validating these parameters.
// responsible for parsing and validating these parameters.
// COs will treat these as opaque. Plugins MUST treat these
// as if they take precedence over the parameters field.
// This field SHALL NOT be specified unless the SP has the
Expand Down
2 changes: 1 addition & 1 deletion lib/go/csi/csi.pb.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions spec.md
Original file line number Diff line number Diff line change
Expand Up @@ -856,7 +856,7 @@ message CreateVolumeRequest {
// Plugin specific parameters to apply, passed in as opaque
// key-value pairs. This field is OPTIONAL. The Plugin is
// responsible for parsing and validating these parameters.
// responsible for parsing and validating these parameters.
// COs will treat these as opaque. Plugins MUST treat these
// as if they take precedence over the parameters field.
// This field SHALL NOT be specified unless the SP has the
Expand Down Expand Up @@ -1647,7 +1647,7 @@ The CO MUST implement the specified error recovery behavior when it encounters t

#### `ControllerModifyVolume`

A Controller plugin MUST implement this RPC call if plugin has MODIFY_VOLUME controller capability.
A Controller plugin MUST implement this RPC call if the plugin has the MODIFY_VOLUME controller capability.
This RPC allows the CO to change mutable key attributes of a volume.

This operation MUST be idempotent.
Expand Down Expand Up @@ -1689,7 +1689,7 @@ message ControllerModifyVolumeResponse {
|-----------|-----------|-------------|-------------------|
| Parameters not supported | 3 INVALID_ARGUMENT | Indicates that the CO has specified mutable parameters not supported by the volume. | Caller MAY verify mutable parameters. |
| Exceeds capabilities | 3 INVALID_ARGUMENT | Indicates that the CO has specified capabilities not supported by the volume. | Caller MAY verify volume capabilities by calling ValidateVolumeCapabilities and retry with matching capabilities. |
| Volume does not exist | 5 NOT FOUND | Indicates that a volume corresponding to the specified volume_id does not exist. | Caller MUST verify that the volume_id is correct and that the volume is accessible and has not been deleted before retrying with exponential back off. |
| Volume does not exist | 5 NOT_FOUND | Indicates that a volume corresponding to the specified volume_id does not exist. | Caller MUST verify that the volume_id is correct and that the volume is accessible and has not been deleted before retrying with exponential back off. |

#### `GetCapacity`

Expand Down

0 comments on commit 3e57adf

Please sign in to comment.