Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change required capability for published_node_ids in GetVolume #487

Merged
merged 1 commit into from
Sep 15, 2021
Merged

Change required capability for published_node_ids in GetVolume #487

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions csi.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -922,7 +922,7 @@ message ControllerGetVolumeResponse {
// A list of all the `node_id` of nodes that this volume is
// controller published on.
// This field is OPTIONAL.
// This field MUST be specified if the PUBLISH_UNPUBLISH_VOLUME
// This field MUST be specified if the LIST_VOLUMES_PUBLISHED_NODES
// controller capability is supported.
// published_node_ids MAY include nodes not published to or
// reported by the SP. The CO MUST be resilient to that.
Expand Down Expand Up @@ -1049,7 +1049,9 @@ message ControllerServiceCapability {
EXPAND_VOLUME = 9;

// Indicates the SP supports the
// ListVolumesResponse.entry.published_nodes field
// ListVolumesResponse.entry.published_node_ids field and the
// ControllerGetVolumeResponse.published_node_ids field.
// The SP MUST also support PUBLISH_UNPUBLISH_VOLUME.
LIST_VOLUMES_PUBLISHED_NODES = 10;

// Indicates that the Controller service can report volume
Expand Down
6 changes: 4 additions & 2 deletions spec.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1553,7 +1553,7 @@ message ControllerGetVolumeResponse {
// A list of all the `node_id` of nodes that this volume is
// controller published on.
// This field is OPTIONAL.
// This field MUST be specified if the PUBLISH_UNPUBLISH_VOLUME
// This field MUST be specified if the LIST_VOLUMES_PUBLISHED_NODES
// controller capability is supported.
// published_node_ids MAY include nodes not published to or
// reported by the SP. The CO MUST be resilient to that.
Expand Down Expand Up @@ -1709,7 +1709,9 @@ message ControllerServiceCapability {
EXPAND_VOLUME = 9;

// Indicates the SP supports the
// ListVolumesResponse.entry.published_nodes field
// ListVolumesResponse.entry.published_node_ids field and the
// ControllerGetVolumeResponse.published_node_ids field.
// The SP MUST also support PUBLISH_UNPUBLISH_VOLUME.
LIST_VOLUMES_PUBLISHED_NODES = 10;

// Indicates that the Controller service can report volume
Expand Down