-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add Wally #2249
feat: add Wally #2249
Conversation
8b7f90e
to
8404e0c
Compare
8404e0c
to
4e76c0c
Compare
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
did you validated that wally uses system libssl and doesn't include it?
I'll prepare our own prebuilds soon |
I'll resolve the comments and split those changes into another PR soon then 👍🏿 |
https://github.com/containerbase/wally-prebuild/releases/tag/0.3.2 💪 aarch64 binaries are coming in a couple of minutes |
@guidojw any chance to continue soon? |
@viceice resolved comments and updated code to latest project standards 👍🏿 |
The prebuilds repository README says focal is supported, but the code here will error on that due to the libssl error, is that a problem? https://github.com/containerbase/wally-prebuild?tab=readme-ov-file#local-development |
you need a noble workaround: base/src/cli/tools/php/index.ts Lines 93 to 96 in 9f9475a
|
Head branch was pushed to by a user without write access
5027c7a
Adds support for the Wally package manager.
renovatebot/renovate#25339
Installing Wally on Ubuntu focal will cause libssl errors. I tried installing the correct libssl here in a prepare class but that was too much of a hassle where it needs jammy apt sources in order to even be able to find the version, but for its dependencies too, so in the end I made it throw an error instead.