Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Wally #2249

Merged
merged 16 commits into from
Dec 21, 2024
Merged

feat: add Wally #2249

merged 16 commits into from
Dec 21, 2024

Conversation

guidojw
Copy link
Contributor

@guidojw guidojw commented Feb 24, 2024

Adds support for the Wally package manager.
renovatebot/renovate#25339

Installing Wally on Ubuntu focal will cause libssl errors. I tried installing the correct libssl here in a prepare class but that was too much of a hassle where it needs jammy apt sources in order to even be able to find the version, but for its dependencies too, so in the end I made it throw an error instead.

@guidojw guidojw force-pushed the feat/wally-tool branch 2 times, most recently from 8b7f90e to 8404e0c Compare February 24, 2024 21:03
@guidojw

This comment was marked as resolved.

@rarkins rarkins requested a review from viceice February 25, 2024 06:12
@rarkins

This comment was marked as outdated.

@guidojw

This comment was marked as outdated.

@rarkins

This comment was marked as outdated.

@guidojw

This comment was marked as outdated.

@guidojw guidojw marked this pull request as draft February 25, 2024 15:53
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did you validated that wally uses system libssl and doesn't include it?

test/latest/Dockerfile Outdated Show resolved Hide resolved
test/latest/Dockerfile Outdated Show resolved Hide resolved
@viceice viceice added the status:blocked Issue is blocked by another issue or external requirement label Feb 28, 2024
@viceice
Copy link
Member

viceice commented Aug 1, 2024

I'll prepare our own prebuilds soon

@guidojw
Copy link
Contributor Author

guidojw commented Aug 6, 2024

I'll resolve the comments and split those changes into another PR soon then 👍🏿

@viceice
Copy link
Member

viceice commented Aug 12, 2024

https://github.com/containerbase/wally-prebuild/releases/tag/0.3.2 💪 aarch64 binaries are coming in a couple of minutes

@viceice viceice removed the status:blocked Issue is blocked by another issue or external requirement label Aug 12, 2024
@viceice
Copy link
Member

viceice commented Dec 6, 2024

@guidojw any chance to continue soon?

@guidojw guidojw marked this pull request as ready for review December 7, 2024 23:09
@guidojw
Copy link
Contributor Author

guidojw commented Dec 7, 2024

@viceice resolved comments and updated code to latest project standards 👍🏿

@guidojw
Copy link
Contributor Author

guidojw commented Dec 7, 2024

The prebuilds repository README says focal is supported, but the code here will error on that due to the libssl error, is that a problem? https://github.com/containerbase/wally-prebuild?tab=readme-ov-file#local-development

docs/custom-registries.md Outdated Show resolved Hide resolved
src/cli/tools/wally.ts Outdated Show resolved Hide resolved
test/latest/Dockerfile Outdated Show resolved Hide resolved
@viceice
Copy link
Member

viceice commented Dec 11, 2024

image
use the re-request review button to request a new review 😉

@guidojw guidojw requested a review from viceice December 11, 2024 23:28
docs/custom-registries.md Outdated Show resolved Hide resolved
@viceice viceice enabled auto-merge December 12, 2024 08:49
@viceice viceice disabled auto-merge December 12, 2024 08:51
@viceice viceice enabled auto-merge December 12, 2024 08:56
@viceice
Copy link
Member

viceice commented Dec 12, 2024

you need a noble workaround:

if (code === 'noble') {
logger.debug(`Using jammy prebuild for ${name} on ${code}`);
code = 'jammy';
}

auto-merge was automatically disabled December 20, 2024 22:05

Head branch was pushed to by a user without write access

@guidojw guidojw requested a review from viceice December 20, 2024 22:05
@viceice viceice enabled auto-merge December 21, 2024 09:08
@viceice viceice added this pull request to the merge queue Dec 21, 2024
Merged via the queue into containerbase:main with commit 5027c7a Dec 21, 2024
29 of 31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants