[Feat.] Converting ociv1 layer blob to turboOCI blob locally. #263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BigVan
force-pushed
the
conv2turbo
branch
3 times, most recently
from
a975fe9
to
96f0a67
Compare
WaberZhuang
suggested changes
Feb 27, 2024
pkg/snapshot/storage.go
Outdated
| Dir: o.upperPath(id), | ||
| File: o.turboOCIFsMeta(id), | ||
| File: o.magicFilePath(id), |
There was a problem hiding this comment.
This will cause previous turbo indexes to not work properly.
pkg/types/types.go
Outdated
| // output options | ||
| Ext4FSMetaPath string | ||
| // (TODO) GzipIndexPath string | ||
| } |
There was a problem hiding this comment.
I suggest not creating this new package. Structures of overlaybd device config could remain in the package snapshot, and ConvertOption should be placed in utils.
There was a problem hiding this comment.
I tried it. but circular dependency happened
With proxyDiffer, containerd can decompress tgz layer and convert it to turboOCI blob without unpack tarball It is very effective in reducing disk I/O pressure because of replacing unpack multiple files with generating ext4 fsmeta. Signed-off-by: Yifan Yuan <tuji.yyf@alibaba-inc.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With proxyDiffer, containerd can decompress tgz layer and convert it to turboOCI blob without unpacking tarball
It is very effective in reducing disk I/O pressure because of replacing unpack multiple files with generating ext4 fsmeta.
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Please check the following list: