cgroup: Optionally add process and task to a subsystems subset #203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Need to rebase |
sameo
force-pushed
the
topic/subsystem-filter
branch
from
48526f0 to
2ea5283
Compare
|
@fuweid The PR is rebased now. |
2 tasks
mxpv
approved these changes
Jul 29, 2021
kzys
approved these changes
Aug 12, 2021
mikebrow
reviewed
Sep 20, 2021
| // Add moves the provided process into the new cgroup | ||
| func (c *cgroup) Add(process Process) error { | ||
| return c.add(process, cgroupProcs) | ||
| func (c *cgroup) Add(process Process, subsystems ...Name) error { |
There was a problem hiding this comment.
Can we update the inline function descriptions too..
control.go
Outdated
| // the cgroup subsystems. When giving AddProc a list of subsystem names, the process | ||
| // id is only added to those subsystems, provided that they are active in the targeted | ||
| // cgroup. | ||
| AddProc(pid uint64, subsystems ...Name) error |
There was a problem hiding this comment.
declaration isn't consistent with the other two.. as it includes subsystems
There was a problem hiding this comment.
The original AddProc declarartion was not consistent with the other methods as it had a named parameter (which is why I had to name the added one...). I'm fixing that too.
| @@ -101,6 +101,50 @@ func TestAdd(t *testing.T) { | |||
| } | |||
| } | |||
|
|
|||
| func TestAddFilteredSubsystems(t *testing.T) { | |||
There was a problem hiding this comment.
let's also test against nil filteredSubstems..
In some cases, one may want to add processes and task only to certain subsystems in a cgroup. For example, when a cgroup is created to only limit a given subsystem usage, but leaves all other subsystems unconstrained, there may be a need to move a process to only the contrained cgroup subsystem while leaving it in another cgroup for other subsystems. This commit makes the Control interface process and task addition functions variadic, in order to pass an optional list of subsystems that behave as s subsystems filter. Signed-off-by: Samuel Ortiz <samuel.e.ortiz@protonmail.com>
sameo
force-pushed
the
topic/subsystem-filter
branch
from
2ea5283 to
80a7821
Compare
dmcgowan
approved these changes
Oct 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases, one may want to add processes and task only to certain
subsystems in a cgroup. For example, when a cgroup is created to only
limit a given subsystem usage, but leaves all other subsystems
unconstrained, there may be a need to move a process to only the
contrained cgroup subsystem while leaving it in another cgroup for
other subsystems.
This commit makes the Control interface process and task addition
functions variadic, in order to pass an optional list of subsystems that
behave as s subsystems filter.
Signed-off-by: Samuel Ortiz samuel.e.ortiz@protonmail.com