Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make cmd/ a separate module (as it's only for testing) #226

Merged
merged 1 commit into from
Mar 25, 2022

Conversation

thaJeztah
Copy link
Member

@thaJeztah thaJeztah commented Mar 21, 2022

To my knowledge, the cmd/cgctl utility is only for testing (also see 7bf30d7), and its dependencies should therefore not be needed as dependencies for the main module.

This patch adds a go.mod in the cmd/ directory to make it it's own module. A replace rule is included in that go.mod to make it use the local version of github.com/containerd/cgroups when building.

To my knowledge, the `cmd/cgctl` utility is only for testing, and
its dependencies should therefore not be needed as dependencies for
the main module.

This patch adds a `go.mod` in the `cmd/` directory to make it it's own
module. A replace rule is included in that `go.mod` to make it use the
local version of github.com/containerd/cgroups when building.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Copy link
Member

@kzys kzys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants