Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: bump up golangci-lint to v1.55.0 #9290

Merged
merged 1 commit into from
Oct 25, 2023
Merged

ci: bump up golangci-lint to v1.55.0 #9290

merged 1 commit into from
Oct 25, 2023

Conversation

ktock
Copy link
Member

@ktock ktock commented Oct 24, 2023

@k8s-ci-robot
Copy link

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ktock
Copy link
Member Author

ktock commented Oct 24, 2023 •
edited
Loading

Linter fails in windows-2019 but no line info is provided temporary made visible via --out-format=colored-line-number for debugging.

  Warning: indent-error-flow: if block ends with a return statement, so drop this else and outdent its block (revive)
  
  Error: issues found
  Ran golangci-lint in 298923ms

@ktock ktock force-pushed the golangci-lint-1.55.0 branch 2 times, most recently from 0a66d7c to 5849ed9 Compare October 24, 2023 01:23
@ktock
ci: bump up golangci-lint to v1.55.0
9fc407d 
Signed-off-by: Kohei Tokunaga <ktokunaga.mail@gmail.com>
@ktock ktock force-pushed the golangci-lint-1.55.0 branch from 5849ed9 to 9fc407d Compare October 24, 2023 01:34
@ktock ktock marked this pull request as ready for review October 24, 2023 05:17
@dmcgowan dmcgowan added this pull request to the merge queue Oct 25, 2023
Merged via the queue into containerd:main with commit f74ca32 Oct 25, 2023
38 of 39 checks passed
@estesp estesp mentioned this pull request Dec 1, 2023
Merged
kiashok added a commit to kiashok/containerd-containerd that referenced this pull request Oct 23, 2024
@kiashok
Merged PR 9121769: Update fork-external main with upstream main
bad3414 
Update fork-external main with upstream main @ 452ec25

Related work items: containerd#5890, containerd#7647, containerd#9218, containerd#9233, containerd#9258, containerd#9270, containerd#9274, containerd#9279, containerd#9283, containerd#9286, containerd#9289, containerd#9290, containerd#9294, containerd#9295, containerd#9297, containerd#9305, containerd#9306, containerd#9308, containerd#9316, containerd#9317, containerd#9319, containerd#9320, containerd#9321
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@henry118 henry118 henry118 approved these changes

@dmcgowan dmcgowan dmcgowan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ktock @k8s-ci-robot @dmcgowan @henry118