-
Notifications
You must be signed in to change notification settings - Fork 348
[release/1.4] append envs from image config to empty slice to avoid env lost #1628
[release/1.4] append envs from image config to empty slice to avoid env lost #1628
Conversation
Signed-off-by: Yadong Zhang <yadzhang@gmail.com> (cherry picked from commit containerd/containerd@08318b1) Signed-off-by: Shengjing Zhu <zhsj@debian.org>
Signed-off-by: Justin Terry (SF) <juterry@microsoft.com> (cherry picked from commit containerd/containerd@06e4e09) Signed-off-by: Shengjing Zhu <zhsj@debian.org>
Hi @zhsj. Thanks for your PR. I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/ok-to-test |
/test pull-cri-containerd-node-e2e |
/ok-to-test |
The CI doesn't update the status. |
@zhsj: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Looks like it is CI issue. Not related to the change. |
@dims did the path change ..
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Backport containerd/containerd#5024 and containerd/containerd#5054