Skip to content
This repository has been archived by the owner on Mar 9, 2022. It is now read-only.

[release/1.4] append envs from image config to empty slice to avoid env lost #1628

Merged
merged 2 commits into from
Mar 2, 2021

Conversation

zhsj
Copy link
Contributor

@zhsj zhsj commented Feb 26, 2021

zhsj added 2 commits February 27, 2021 01:48
Signed-off-by: Yadong Zhang <yadzhang@gmail.com>

(cherry picked from commit containerd/containerd@08318b1)

Signed-off-by: Shengjing Zhu <zhsj@debian.org>
Signed-off-by: Justin Terry (SF) <juterry@microsoft.com>

(cherry picked from commit containerd/containerd@06e4e09)

Signed-off-by: Shengjing Zhu <zhsj@debian.org>
@k8s-ci-robot
Copy link

Hi @zhsj. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Member

@kevpar kevpar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@Zyqsempai Zyqsempai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mikebrow
Copy link
Member

/ok-to-test

@fuweid
Copy link
Member

fuweid commented Mar 2, 2021

/test pull-cri-containerd-node-e2e

@fuweid
Copy link
Member

fuweid commented Mar 2, 2021

/ok-to-test

@fuweid
Copy link
Member

fuweid commented Mar 2, 2021

pull-cri-containerd-node-e2e Pending — Job triggered

The CI doesn't update the status.

@fuweid fuweid closed this Mar 2, 2021
@fuweid fuweid reopened this Mar 2, 2021
@k8s-ci-robot
Copy link

@zhsj: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-cri-containerd-node-e2e e4fcda3 link /test pull-cri-containerd-node-e2e

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@fuweid
Copy link
Member

fuweid commented Mar 2, 2021

zone=us-central1-f --ssh-user=prow --ssh-key=/workspace/.ssh/google_compute_engine --ginkgo-flags=--nodes=8 --focus="[NodeConformance]|[NodeFeature:.+]" --skip="[Flaky]|[Slow]|[Serial]" --test_args=--container-runtime=remote --container-runtime-endpoint=unix:///run/containerd/containerd.sock --container-runtime-process-name=/home/containerd/usr/local/bin/containerd --container-runtime-pid-file= --kubelet-flags="--cgroups-per-qos=true --cgroup-root=/ --runtime-cgroups=/system.slice/containerd.service" --extra-log="{"name": "containerd.log", "journalctl": ["-u", "containerd"]}" --test-timeout=1h5m0s --image-config-file=/home/prow/go/src/k8s.io/test-infra/jobs/e2e_node/containerd/cri-master/image-config-pr.yaml -node-env=PULL_REFS=release/1.4:b4b894c871860664fe5c0509df68da0dbae9f095,1628:e4fcda3215cc607cc1f10657f76cbf85313fd64c (interrupted): exit status 1

Looks like it is CI issue. Not related to the change.

@mikebrow
Copy link
Member

mikebrow commented Mar 2, 2021

@dims did the path change .. cri-c8d-pr-node-e2e for both containerd/containerd and containerd/cri infra?

Looking for address 'bootstrap-e2e-master-ip'
ERROR: (gcloud.compute.addresses.describe) Could not fetch resource:
 - The resource 'projects/cri-c8d-pr-node-e2e/regions/us-central1/addresses/bootstrap-e2e-master-ip' was not found

Copy link
Member

@mikebrow mikebrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants