Lock to OS thread when Pdeathsig is set #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 21.52% // Head: 20.27% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #86 +/- ##
==========================================
- Coverage 21.52% 20.27% -1.26%
==========================================
Files 7 7
Lines 683 735 +52
==========================================
+ Hits 147 149 +2
- Misses 499 545 +46
- Partials 37 41 +4
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
This has been open for quite awhile. Is there anyone specific I can ping to review it? |
samuelkarp
requested changes
Sep 7, 2022
aaronlehmann
force-pushed
the
lock-os-thread
branch
from
a9d1516
to
51f9c48
Compare
samuelkarp
requested changes
Sep 8, 2022
See golang/go#27505 for context. Pdeathsig isn't safe to set without locking to the current OS thread, because otherwise thread termination will send the signal, which isn't the desired behavior. I discovered this while troubleshooting a problem that turned out to be unrelated, but I think it's necessary for correctness. Signed-off-by: Aaron Lehmann <alehmann@netflix.com>
aaronlehmann
force-pushed
the
lock-os-thread
branch
from
51f9c48
to
1caf1a7
Compare
samuelkarp
approved these changes
Sep 9, 2022
samuelkarp
dismissed
estesp’s stale review
Changes since previous approval, sorry @estesp!
|
Not in a huge rush for this one, but would just like to get it merged so we can close the book on it. Is there anything else you need from me to push it forward? |
kzys
approved these changes
Oct 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See golang/go#27505 for context.
Pdeathsigisn't safe to set without locking to the current OS thread, because
otherwise thread termination will send the signal, which isn't the
desired behavior.
I discovered this while troubleshooting a problem that turned out to be
unrelated, but I think it's necessary for correctness.
cc @coryb