-
Notifications
You must be signed in to change notification settings - Fork 606
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add compose run
command
#1340
Conversation
Signed-off-by: Min Uk Lee <minuk.dev@gmail.com>
This comment was marked as resolved.
This comment was marked as resolved.
I added some test cases for |
Signed-off-by: Min Uk Lee <minuk.dev@gmail.com>
Signed-off-by: Min Uk Lee <minuk.dev@gmail.com>
Signed-off-by: Min Uk Lee <minuk.dev@gmail.com> rewrite testcode test commit
Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, and sorry for delay in reviewing
Found a minor incompatibility: |
LGTM |
@AkihiroSuda could you plz ask for squashing commits before merging the PR in the future :) ! |
In this case having separate commits is fine, as each of the commits has a separate topic.
|
Signed-off-by: Min Uk Lee minuk.dev@gmail.com
close #270
Changes (for more details, see each item below):
-d
from default RunArgs of serviceparser.Containerapt install expect
into docker-compatibility testcompose run
command (no details below)compose run
docs into README.md (no details below)Unimplmented Flags:
--no-TTY
,--use-aliases
Not tested Flags:- volumes, entrypoint(I'll add additional test commit as soon as possible. I'm trying to figure out how to test it properly.)(Add test cases)Details
remove
-d
from default RunArgs of serviceparser.Container-d
flag to find cid.--interactive
flag ofcompose run
andStdinOpen
option of compose-spec-d
from default RunArgs and explicitly add property of container. Containers are now possible to determine whether or not to detach when they really start to run.--cid-file
flag to find it.add
apt install expect
into docker-compatibility testunbuffer
command to emulate tty.unbuffer
command from a test for run command.unbuffer
is not installed.add Base.ComposeCmdWithHelper() into testutil
unbuffer
needs to emulate tty to testcompose run
.