Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: support filter argument for nerdctl ps command #1342

Merged
merged 1 commit into from
Sep 3, 2022
Merged

Feat: support filter argument for nerdctl ps command #1342

merged 1 commit into from
Sep 3, 2022

Conversation

yuchanns
Copy link
Contributor

Fix #1339

Signed-off-by: Hanchin Hsieh me@yuchanns.xyz

@Zheaoli
Copy link
Member

Zheaoli commented Aug 28, 2022

maybe you need checkout about container ls command. It's a little bit different with ps

@Zheaoli Zheaoli requested review from junnplus, Zheaoli and AkihiroSuda and removed request for junnplus August 28, 2022 18:53
@Zheaoli Zheaoli added enhancement New feature or request kind/feature labels Aug 28, 2022
@Zheaoli Zheaoli added this to the v0.22.3 milestone Aug 28, 2022
Zheaoli
Zheaoli reviewed Aug 28, 2022
View reviewed changes
cmd/nerdctl/ps.go Outdated Show resolved Hide resolved
@yuchanns
Copy link
Contributor Author

ok. Need some time to figure out what is the exact difference between ps and container ls.

@AkihiroSuda
Copy link
Member

what is the exact difference between ps and container ls.

Same

@yuchanns
Copy link
Contributor Author

yuchanns commented Aug 30, 2022 •
edited
Loading

Same

Exactly.

maybe you need checkout about container ls command. It's a little bit different with ps

https://github.com/docker/cli/blob/6205b4eae6a116236edc04876e9c6631c823290b/cli/command/container/list.go#L62-L67

I don't see anything different in Docker's implementation. @Zheaoli

@yuchanns
Support filter argument for nerdctl ps command
0691b36 
Signed-off-by: Hanchin Hsieh <me@yuchanns.xyz>
AkihiroSuda
AkihiroSuda approved these changes Sep 3, 2022
View reviewed changes
Copy link
Member

@AkihiroSuda AkihiroSuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, merging

@AkihiroSuda AkihiroSuda merged commit b89f247 into containerd:master Sep 3, 2022
@yuchanns yuchanns deleted the support-1339 branch September 3, 2022 06:12
@AkihiroSuda AkihiroSuda mentioned this pull request Sep 8, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AkihiroSuda AkihiroSuda AkihiroSuda approved these changes

@junnplus junnplus Awaiting requested review from junnplus

@Zheaoli Zheaoli Awaiting requested review from Zheaoli

Assignees
No one assigned
Labels
enhancement New feature or request kind/feature
Projects
None yet
Milestone
v0.23.0
Development

Successfully merging this pull request may close these issues.

Support filter argument in nerdctl container ls command
3 participants
@yuchanns @Zheaoli @AkihiroSuda