Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINTAINERS: add Hanchin Hsieh (yuchanns) as a REVIEWER #1540

Merged
merged 1 commit into from
Nov 30, 2022

Conversation

AkihiroSuda
Copy link
Member

@AkihiroSuda AkihiroSuda commented Nov 22, 2022

Hanchin Hsieh (@yuchanns) has been very actively contributing to the project:
https://github.com/containerd/nerdctl/pulls?q=author%3Ayuchanns+

So I'd like to invite @yuchanns as a reviewer.

Needs explicit LGTM from @yuchanns and 1/3 of the nerdctl Committers ( $ceil \left( 1 \times \frac{2}{3} \right) = 1$ ), according to https://github.com/containerd/project/blob/main/GOVERNANCE.md :

After a candidate has been informally proposed in the maintainers forum, the
existing maintainers are given seven days to discuss the candidate, raise
objections and show their support. Formal voting takes place on a pull request
that adds the contributor to the MAINTAINERS file. Candidates must be approved
by 2/3 of the current committers by adding their approval or LGTM to the pull
request. The reviewer role has the same process but only requires 1/3 of current
committers.

If a candidate is approved, they will be invited to add their own LGTM or
approval to the pull request to acknowledge their agreement. A committer will
verify the numbers of votes that have been received and the allotted seven days
have passed, then merge the pull request and invite the contributor to the
organization.

For non-core sub-projects, only committers of the repository that the candidate
is proposed for are given votes.

I'd also like to get a few LGTMs from the Core Committers too. (not necessary)

This PR will remain open for 7 days.

Copy link
Member

@Zheaoli Zheaoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome!

@yuchanns
Copy link
Contributor

LGTM

Copy link
Member

@fahedouch fahedouch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Welcome @yuchanns !

Copy link
Member

@ktock ktock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@junnplus junnplus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Welcome~

Copy link
Member

@fuweid fuweid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
@AkihiroSuda AkihiroSuda merged commit 4cae8de into containerd:main Nov 30, 2022
@AkihiroSuda AkihiroSuda added this to the v1.1.0 milestone Nov 30, 2022
@AkihiroSuda
Copy link
Member Author

欢迎加入~ @yuchanns

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants