-
Notifications
You must be signed in to change notification settings - Fork 606
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MAINTAINERS: add Hanchin Hsieh (yuchanns) as a REVIEWER #1540
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome!
LGTM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, Welcome @yuchanns !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, Welcome~
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
d76cbd2
to
1767349
Compare
欢迎加入~ @yuchanns |
Hanchin Hsieh (@yuchanns) has been very actively contributing to the project:
https://github.com/containerd/nerdctl/pulls?q=author%3Ayuchanns+
So I'd like to invite @yuchanns as a reviewer.
Needs explicit LGTM from @yuchanns and 1/3 of the nerdctl Committers ($ceil \left( 1 \times \frac{2}{3} \right) = 1$ ), according to https://github.com/containerd/project/blob/main/GOVERNANCE.md :
I'd also like to get a few LGTMs from the Core Committers too. (not necessary)
This PR will remain open for 7 days.