Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: propagate SOURCE_DATE_EPOCH from the client env #1926

Merged
merged 1 commit into from
Jan 26, 2023
Merged

build: propagate SOURCE_DATE_EPOCH from the client env #1926

merged 1 commit into from
Jan 26, 2023

Conversation

AkihiroSuda
Copy link
Member

@AkihiroSuda AkihiroSuda added this to the v1.2.0 milestone Jan 25, 2023
manugupt1
manugupt1 reviewed Jan 26, 2023
View reviewed changes
cmd/nerdctl/builder_build_test.go Outdated
testutil.DockerIncompatible(t) // Needs buildx v0.10 (https://github.com/docker/buildx/pull/1489)
base := testutil.NewBase(t)
imageName := testutil.Identifier(t)
defer base.Cmd("rmi", imageName).Run()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: can this be AssertOK

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@AkihiroSuda
build: propagate SOURCE_DATE_EPOCH from the client env
0f254af 
Port docker/buildx PR 1482

Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
@ktock ktock merged commit d39e9c8 into containerd:main Jan 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manugupt1 manugupt1 manugupt1 approved these changes

@ktock ktock ktock approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@AkihiroSuda @manugupt1 @ktock