Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

compose: implement Bind.CreateHostPath #2150

Merged
merged 1 commit into from
Apr 5, 2023
Merged

compose: implement Bind.CreateHostPath #2150

merged 1 commit into from
Apr 5, 2023

Conversation

AkihiroSuda
Copy link
Member

Fix #1652

@AkihiroSuda AkihiroSuda added enhancement New feature or request area/compose labels Apr 4, 2023
@AkihiroSuda AkihiroSuda added this to the v1.3.0 milestone Apr 4, 2023
@AkihiroSuda AkihiroSuda marked this pull request as draft April 4, 2023 19:42
@AkihiroSuda AkihiroSuda force-pushed the create-host-path branch 2 times, most recently from 7eb9be8 to 97f1a36 Compare April 5, 2023 10:20
@AkihiroSuda AkihiroSuda marked this pull request as ready for review April 5, 2023 10:20
@AkihiroSuda
compose: implement Bind.CreateHostPath
a620083 
Fix issue 1652

Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
@AkihiroSuda AkihiroSuda modified the milestones: v1.3.0, v1.4.0 (tentative) Apr 5, 2023
fahedouch
fahedouch approved these changes Apr 5, 2023
View reviewed changes
Copy link
Member

@fahedouch fahedouch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@fahedouch fahedouch merged commit 1525035 into containerd:main Apr 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fahedouch fahedouch fahedouch approved these changes

Assignees
No one assigned
Labels
area/compose enhancement New feature or request
Projects
None yet
Milestone
v1.3.1
Development

Successfully merging this pull request may close these issues.

Bind mount throws error if the directory does not exit beforehand
2 participants
@AkihiroSuda @fahedouch