fix nerdctl exec init console size 0 0 problem #2182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fahedouch
reviewed
Apr 15, 2023
pkg/cmd/container/exec.go
Outdated
| @@ -181,3 +184,11 @@ func generateExecProcessSpec(ctx context.Context, client *containerd.Client, con | |||
|
|
|||
| return pspec, nil | |||
| } | |||
|
|
|||
| func setInitialTTYSize(pspec *specs.Process) { | |||
There was a problem hiding this comment.
I think it's a function works more like specs.Process' decorator, so it's not so proper to go to consoleutil
pkg/cmd/container/exec.go
Outdated
| func setInitialTTYSize(pspec *specs.Process) { | ||
| size, err := console.Current().Size() | ||
| if err != nil { | ||
| size.Height, size.Width = 0, 0 |
There was a problem hiding this comment.
why override with 0, 0 values ?
may be
size, err := console.Current().Size()
if err == nil {
pspec.ConsoleSize = &specs.Box{Height: uint(size.Height), Width: uint(size.Width)}
}
There was a problem hiding this comment.
that's right, I've change codes now
|
would you please squash your commits, you can ping me if you need some help. Thanks |
Signed-off-by: ChangJH-Mark <1431293514@qq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
currently
nerdctl exec -itinitial tty size is0 0, switch it to current console size