Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for nerdctl build on Windows #2587

Merged
merged 4 commits into from
Apr 8, 2024
Merged

Support for nerdctl build on Windows #2587

merged 4 commits into from
Apr 8, 2024

Commits on Apr 8, 2024

  1. Remove unused defaults.BuildKitHost 

    Although it was being shown in the help output, the value was ignored in
favour of auto-detection by getBuildkitHost, which could give different
results anyway.

Signed-off-by: Paul "TBBle" Hampson <Paul.Hampson@Pobox.com>
    @TBBle
    TBBle committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    0d75e34 View commit details
    Browse the repository at this point in the history

  2. Enable building on Windows hosts 

    This of course requires functional BuildKit for Windows.

Signed-off-by: Paul "TBBle" Hampson <Paul.Hampson@Pobox.com>
    @TBBle
    TBBle committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    6e6aa4a View commit details
    Browse the repository at this point in the history

  3. Implement autodetection of Windows buildkitd socket 

    Buildkit on Windows doesn't support rootless mode, and doesn't put the
namespace into the pipe name currently, so the Windows version is
near-trivial.

This also corrects the autodetection path on FreeBSD to start in
/var/run instead of current Linux FHS's /run, and doesn't bother trying
to support Rootless mode and related path guessing on FreeBSD.

Signed-off-by: Paul "TBBle" Hampson <Paul.Hampson@Pobox.com>
    @TBBle
    TBBle committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    5fac99b View commit details
    Browse the repository at this point in the history

  4. Rationalise build constraints for Go 1.19 onwards 

    This mostly involves replacing anything that was trying to be "Not
Windows" with the new-in-Go-1.19 "unix" build-constraint. Effectively,
anything that contained both "linux" and "freebsd" but not "windows", or
excluded only "windows", is now "unix".

A couple of needless constraints were removed when the filenames already
carried the appropriate constraint.

A handful of files were renamed, so that now "unix"-suffixed files all
use the "unix" constraint, and "other" is used when the constraint is
more-complex, for "no specific implementation" cases.

Signed-off-by: Paul "TBBle" Hampson <Paul.Hampson@Pobox.com>
    @TBBle
    TBBle committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    b5117a2 View commit details
    Browse the repository at this point in the history