Add --allow option in build
#2746
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AkihiroSuda
reviewed
Jan 12, 2024
docs/command-reference.md
Outdated
| @@ -681,6 +681,7 @@ Flags: | |||
| - :whale: `type=image,name=example.com/image,push=true`: Push to a registry (see [`buildctl build`](https://github.com/moby/buildkit/tree/v0.9.0#imageregistry) documentation) | |||
| - :whale: `--progress=(auto|plain|tty)`: Set type of progress output (auto, plain, tty). Use plain to show container output | |||
| - :whale: `--secret`: Secret file to expose to the build: id=mysecret,src=/local/secret | |||
| - :whale: `--allow`: Allow extra privileged entitlement, e.g. network.host, security.insecure | |||
There was a problem hiding this comment.
Maybe have a link to how to configure the entitlements
https://github.com/moby/buildkit/blob/master/docs/buildkitd.toml.md
There was a problem hiding this comment.
Thanks @AkihiroSuda
The docs has been added :-)
AkihiroSuda
reviewed
Jan 12, 2024
| @@ -51,6 +51,7 @@ If Dockerfile is not present and -f is not specified, it will look for Container | |||
| buildCommand.Flags().StringP("output", "o", "", "Output destination (format: type=local,dest=path)") | |||
| buildCommand.Flags().String("progress", "auto", "Set type of progress output (auto, plain, tty). Use plain to show container output") | |||
| buildCommand.Flags().StringArray("secret", nil, "Secret file to expose to the build: id=mysecret,src=/local/secret") | |||
| buildCommand.Flags().StringArray("allow", nil, "Allow extra privileged entitlement, e.g. network.host, security.insecure") | |||
There was a problem hiding this comment.
Can we have a shell completion?
There was a problem hiding this comment.
Thanks @AkihiroSuda
Shell completion has been added :-)
Signed-off-by: Kay Yan <kay.yan@daocloud.io>
yankay
force-pushed
the
add-build-flag-allow
branch
from
9c863d2
to
5ee55f2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #2744