Support nerdctl build args: --attest, --sbom,--provenance
#2786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yankay
changed the title
nerdctl build --attest, --sbom,provenancenerdctl build args: --attest, --sbom,provenance
yankay
force-pushed
the
support-build-attest
branch
from
43a41e0
to
43b059f
Compare
yankay
changed the title
nerdctl build args: --attest, --sbom,provenancenerdctl build args: --attest, --sbom,--provenance
yankay
force-pushed
the
support-build-attest
branch
7 times, most recently
from
555c36f
to
8d11bab
Compare
yankay
changed the title
nerdctl build args: --attest, --sbom,--provenancenerdctl build args: --attest, --sbom,--provenance
yankay
force-pushed
the
support-build-attest
branch
7 times, most recently
from
a2e992d
to
cb4e3b7
Compare
yankay
changed the title
nerdctl build args: --attest, --sbom,--provenancenerdctl build args: --attest, --sbom,--provenance
yankay
force-pushed
the
support-build-attest
branch
from
cb4e3b7
to
b7efbbc
Compare
AkihiroSuda
reviewed
Feb 2, 2024
cmd/nerdctl/builder_build_test.go
Outdated
| testutil.RequiresBuild(t) | ||
| base := testutil.NewBase(t) | ||
| if testutil.GetTarget() == testutil.Docker { | ||
| base.Env = append(base.Env, "DOCKER_BUILDKIT=1") |
There was a problem hiding this comment.
Thanks @AkihiroSuda
It has been remove.
AkihiroSuda
reviewed
Feb 2, 2024
cmd/nerdctl/builder_build_test.go
Outdated
| @@ -498,3 +498,50 @@ func TestBuildNetworkShellCompletion(t *testing.T) { | |||
| networkName := "default" | |||
| base.Cmd(gsc, "build", "--network", "").AssertOutContains(networkName) | |||
| } | |||
|
|
|||
| func TestBuildAttestation(t *testing.T) { | |||
| testutil.DockerIncompatible(t) // ref:https://github.com/docker/buildx/issues/1655 | |||
There was a problem hiding this comment.
Can we just create docker-container builder in GHA?
There was a problem hiding this comment.
Thanks @AkihiroSuda
The test is docker-compatible by a docker-builder created in a test case. :-)
yankay
force-pushed
the
support-build-attest
branch
2 times, most recently
from
987c1f1
to
96691fd
Compare
Signed-off-by: Kay Yan <kay.yan@daocloud.io>
yankay
force-pushed
the
support-build-attest
branch
from
96691fd
to
9ae613b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Build attestations describe how an image was built, and what it contains.
Support
nerdctl buildargs:--attest,--sbom,--provenance.fix: #2745