Add image squash command #3756
Open
Add image squash command #3756
+688
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weapons97
force-pushed
the
main
branch
4 times, most recently
from
b7756fe to
9599d0a
Compare
AkihiroSuda
reviewed
Dec 13, 2024
| cmd.Flags().StringP("message", "m", "", "Commit message") | ||
| } | ||
|
|
||
| func NewSquashCommand() *cobra.Command { |
There was a problem hiding this comment.
https://github.com/containerd/nerdctl/blob/main/docs/command-reference.md needs to be updated
AkihiroSuda
reviewed
Dec 13, 2024
cmd/nerdctl/main.go
Outdated
| @@ -295,6 +295,7 @@ Config file ($NERDCTL_TOML): %s | |||
| image.NewTagCommand(), | |||
| image.NewRmiCommand(), | |||
| image.NewHistoryCommand(), | |||
| image.NewSquashCommand(), | |||
There was a problem hiding this comment.
Not a fan of inflating the number of the top-level commands
AkihiroSuda
reviewed
Dec 13, 2024
| } | ||
| } | ||
|
|
||
| // copied from github.com/containerd/containerd/rootfs/apply.go |
There was a problem hiding this comment.
Should be a permanent URL with the git tag (or the commit hash)
There was a problem hiding this comment.
The commit hash has been added.
Signed-off-by: weipeng <weip3@chinatelecom.cn>
weapons97
force-pushed
the
main
branch
2 times, most recently
from
4073bc1 to
05d0370
Compare
Signed-off-by: weipeng <weip3@chinatelecom.cn>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr adds the squash image command.
The related issue is #3252.