Support recursive read-only (RRO) mounts: nerdctl run -v /foo:/bar:rro,rprivate
#511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AkihiroSuda
force-pushed
the
mount-rro
branch
from
f897283
to
94d5ff1
Compare
AkihiroSuda
changed the title
nerdctl run -v /foo:/bar:rronerdctl run -v /foo:/bar:rro,rprivate
AkihiroSuda
force-pushed
the
mount-rro
branch
from
94d5ff1
to
b81198d
Compare
AkihiroSuda
force-pushed
the
mount-rro
branch
from
b81198d
to
dd03a4b
Compare
ktock
approved these changes
Nov 17, 2021
…ro,rprivate` `nerdctl run -v /foo:/bar:rro,rprivate` appends "rro" (in addition to "ro") to the OCI mount option string slice. Requires crun >= 1.4 or runc >= 1.1 (opencontainers/runc PR 3272). Older version of runc just ignores "rro" option. The "rro" option string conforms to the proposal in util-linux/util-linux Issue 1501. Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
AkihiroSuda
force-pushed
the
mount-rro
branch
from
dd03a4b
to
c103287
Compare
|
Amended the commit to mention crun 1.4 |
ktock
approved these changes
Nov 17, 2021
This was referenced Feb 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nerdctl run -v /foo:/bar:rroappends "rro,rprivate" (in addition to "ro") to the OCI mount option string slice.Requires:
Or:
Older version of runc just ignores "rro" option.
The "rro" option string conforms to the proposal in:
MOUNT_ATTR_RDONLY+AT_RECURSIVEutil-linux/util-linux#1501.