change oom score adj for nydus daemon #404
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sctb512
force-pushed
the
change-oom-score-adj-for-daemon
branch
2 times, most recently
from
96e7950
to
10ac95a
Compare
Signed-off-by: Bin Tang <tangbin.bin@bytedance.com>
Nydus-snapshotter does not have a maximum memory limit by default. This can result in host invalidity. We can fix this problem by adding MemoryMax to nydus-snapshotter.service. We can set OOMScoreAdjust=-1000 to prevent killing nydus-snapshotter on OOM. Signed-off-by: Bin Tang <tangbin.bin@bytedance.com>
Signed-off-by: Bin Tang <tangbin.bin@bytedance.com>
sctb512
force-pushed
the
change-oom-score-adj-for-daemon
branch
from
10ac95a
to
bfb8ccb
Compare
changweige
reviewed
Mar 9, 2023
| @@ -40,6 +41,10 @@ func (m *Manager) StartDaemon(d *daemon.Daemon) error { | |||
| defer d.Unlock() | |||
|
|
|||
| d.States.ProcessID = cmd.Process.Pid | |||
| err = oom.ChangeDaemonOOMScoreAdj(d.States.ProcessID, -999) | |||
There was a problem hiding this comment.
Is it possible to make it work as a Daemon method?
|
Another solution is #415 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nydus-snapshotter does not have a maximum memory limit by default. This can result in host invalidity. We can fix this problem by adding MemoryMax to nydus-snapshotter.service. We can set OOMScoreAdjust=-1000 to prevent killing nydus-snapshotter on OOM.