feat: support the arg batch-size for small chunks mergence #445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #445 +/- ##
==========================================
- Coverage 37.15% 37.13% -0.02%
==========================================
Files 60 60
Lines 6909 6912 +3
==========================================
Hits 2567 2567
- Misses 4045 4048 +3
Partials 297 297
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
Desiki-high
changed the title
to support the feature of small chunks mergence in nydus, we need to add the arg batch-size Signed-off-by: Desiki-high <ding_yadong@foxmail.com>
Desiki-high
changed the title
changweige
reviewed
Apr 20, 2023
| @@ -71,6 +71,8 @@ type PackOption struct { | |||
| AlignedChunk bool | |||
| // ChunkSize sets the size of data chunks, must be power of two and between 0x1000-0x1000000. | |||
| ChunkSize string | |||
| // BacthSize sets the size of batch data chunks, must be power of two and between 0x1000-0x1000000 or zero. | |||
| BatchSize string | |||
There was a problem hiding this comment.
What does zero value mean if it is set to zero ?
There was a problem hiding this comment.
What does zero value mean if it is set to zero ?
Zero is the default value of batch-size for nydus-image, it means that the small chunks mergence is unable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the option arg (batch-size) for convert tool and the batch-size arg is new feature for nydus-image, which support merge small file chunks into one batch chunk.
That is the first part of work , other work will in image-service and acceleration-service
This PR is related to dragonflyoss/image-service#1202.