cmd: refine command line help messages and error messages #463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #463 +/- ##
=======================================
Coverage 37.13% 37.13%
=======================================
Files 60 60
Lines 6912 6912
=======================================
Hits 2567 2567
Misses 4048 4048
Partials 297 297
☔ View full report in Codecov by Sentry. |
changweige
reviewed
May 5, 2023
changweige
reviewed
May 5, 2023
changweige
reviewed
May 5, 2023
internal/flags/flags.go
Outdated
| Destination: &args.NydusdConfigPath, | ||
| }, | ||
| &cli.StringFlag{ | ||
| Name: "daemon-mode", | ||
| Usage: "spawning nydusd daemon mode, legal values include \"multiple\", \"shared\" or \"none\"", | ||
| Usage: "nydusd daemon working mode, possible values: \"dedicated\"/\"multiple\", \"shared\" or \"none\"", |
There was a problem hiding this comment.
dedicated should not be included in this PR?
changweige
reviewed
May 5, 2023
Refine command line help messages and error messages. Signed-off-by: Jiang Liu <gerry@linux.alibaba.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refine command line help messages and error messages.