Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

action: remove patch coverage check in workflow #485

Merged
merged 1 commit into from
May 22, 2023

Conversation

adamqqqplay
Copy link
Contributor

In the recent PR #482, the patch coverage requirement seems to be too strict. So we temporarily remove this check and focus on project coverage.

In the recent PR, the patch coverage requirement seems to be too strict.
So we temporarily remove this check and focus on project coverage.

Signed-off-by: Qinqi Qu <quqinqi@linux.alibaba.com>
@codecov
Copy link

codecov bot commented May 22, 2023

Codecov Report

Merging #485 (03ae8fc) into main (10b4835) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #485   +/-   ##
=======================================
  Coverage   37.31%   37.31%           
=======================================
  Files          59       59           
  Lines        6960     6960           
=======================================
  Hits         2597     2597           
  Misses       4052     4052           
  Partials      311      311           

Copy link
Member

@changweige changweige left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@changweige changweige left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@changweige changweige left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@changweige changweige left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@changweige
Copy link
Member

Um, what happens to my Approve button ending up with so many approves  😂

@imeoer imeoer merged commit 4b133ee into containerd:main May 22, 2023
@adamqqqplay adamqqqplay deleted the fix-test-coverage branch May 22, 2023 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants