-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
converter: add feature detection for --batch-size
#489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #489 +/- ##
==========================================
+ Coverage 37.31% 37.78% +0.47%
==========================================
Files 59 59
Lines 6960 6979 +19
==========================================
+ Hits 2597 2637 +40
+ Misses 4052 4031 -21
Partials 311 311
|
imeoer
reviewed
May 31, 2023
hangvane
force-pushed
the
feature-detection
branch
4 times, most recently
from
June 6, 2023 04:51
eff5e6e
to
93b5b40
Compare
hangvane
force-pushed
the
feature-detection
branch
3 times, most recently
from
June 6, 2023 05:21
16a70c0
to
b949e03
Compare
imeoer
reviewed
Jun 6, 2023
hangvane
force-pushed
the
feature-detection
branch
from
June 6, 2023 10:18
b949e03
to
7ae7f5d
Compare
…#482 1. detect features by checking `nydus-image create -h`. 2. Add feature detection for `--batch-size`. Signed-off-by: Wenhao Ren <wenhaoren@mail.dlut.edu.cn>
hangvane
force-pushed
the
feature-detection
branch
from
June 6, 2023 12:05
7ae7f5d
to
536b5c8
Compare
imeoer
approved these changes
Jun 7, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nydus-image create -h
.--batch-size
to keep compatibility with old versions of nydus-image.For old versions of
nydus-image
:This PR is related to #482