Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workflow: fix incorrect files number for optimizer test #491

Merged
merged 3 commits into from
Jun 16, 2023

Conversation

sctb512
Copy link
Member

@sctb512 sctb512 commented Jun 5, 2023

Sometimes, the number of files accessed is not equal to the expected values. In this test, we only need to judge whether the optimizer works. This is sufficient if the number is not equal to 0.

Related to #446

@sctb512 sctb512 changed the title workflow: fix incorrect files number for optimizer test [wip] workflow: fix incorrect files number for optimizer test Jun 5, 2023
@codecov
Copy link

codecov bot commented Jun 5, 2023

Codecov Report

Merging #491 (97a3493) into main (2c1de89) will increase coverage by 0.39%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #491      +/-   ##
==========================================
+ Coverage   37.31%   37.70%   +0.39%     
==========================================
  Files          59       59              
  Lines        6960     6996      +36     
==========================================
+ Hits         2597     2638      +41     
+ Misses       4052     4047       -5     
  Partials      311      311              

see 10 files with indirect coverage changes

@sctb512 sctb512 force-pushed the fix-optimizer-workflow branch 11 times, most recently from c803848 to f3ca8c6 Compare June 15, 2023 07:39
@sctb512 sctb512 changed the title [wip] workflow: fix incorrect files number for optimizer test workflow: fix incorrect files number for optimizer test Jun 15, 2023
Signed-off-by: Bin Tang <tangbin.bin@bytedance.com>
Signed-off-by: Bin Tang <tangbin.bin@bytedance.com>
Copy link
Member

@changweige changweige left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks

@changweige changweige merged commit 9ce8cce into containerd:main Jun 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants