Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd: move nydus-overlayfs from image service to snapshotter #529

Merged
merged 1 commit into from
Sep 11, 2023
Merged

cmd: move nydus-overlayfs from image service to snapshotter #529

merged 1 commit into from
Sep 11, 2023

Conversation

jiangliu
Copy link
Contributor

@jiangliu jiangliu commented Sep 7, 2023

Nydus-overlayfs is a mount helper for nydus-snapshotter, and is only used by nydus-snapshotter. So move it from Image Service into nydus-snapshotter.

@imeoer
Copy link
Collaborator

imeoer commented Sep 7, 2023

Maybe also add some build commands in Makefile.

@jiangliu
Copy link
Contributor Author

jiangliu commented Sep 7, 2023

Maybe also add some build commands in Makefile.

Done, add build target for nydus-overlayfs

@imeoer
Copy link
Collaborator

imeoer commented Sep 8, 2023

It seems have some broken CIs: https://github.com/containerd/nydus-snapshotter/actions/runs/6105239526/job/16568447263?pr=529

@jiangliu
Copy link
Contributor Author

jiangliu commented Sep 8, 2023

It seems have some broken CIs: https://github.com/containerd/nydus-snapshotter/actions/runs/6105239526/job/16568447263?pr=529

Add one step for CI in makefile, now works.

@imeoer
Copy link
Collaborator

imeoer commented Sep 11, 2023

Does this binary is included in the release package? After we removed it from the image-service repo, there was no place to download it.

@jiangliu
Copy link
Contributor Author

Does this binary is included in the release package? After we removed it from the image-service repo, there was no place to download it.

It should be included, but I'm not familiar with github release. So which github file should I modify?

@imeoer
Copy link
Collaborator

imeoer commented Sep 11, 2023

@jiangliu Should be .github/workflows/release.yml, not sure it has been included.

@jiangliu
cmd: move nydus-overlayfs from image service to snapshotter
a48b652 
Nydus-overlayfs is a mount helper for nydus-snapshotter, and is only
used by nydus-snapshotter. So move it from Image Service into
nydus-snapshotter.

Signed-off-by: Jiang Liu <gerry@linux.alibaba.com>
@jiangliu
Copy link
Contributor Author

@jiangliu Should be .github/workflows/release.yml, not sure it has been included.

done

changweige
changweige approved these changes Sep 11, 2023
View reviewed changes
Copy link
Member

@changweige changweige left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

imeoer
imeoer approved these changes Sep 11, 2023
View reviewed changes
Copy link
Collaborator

@imeoer imeoer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@imeoer imeoer merged commit 2f1bfad into containerd:main Sep 11, 2023
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imeoer imeoer imeoer approved these changes

@changweige changweige changweige approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jiangliu @imeoer @changweige