Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

e2e: always disable erofs ondemand-read test and failover test #540

Merged
merged 1 commit into from
Sep 22, 2023

Conversation

changweige
Copy link
Member

Github action has upgraded its worker kernel to 6.2 with CONFIG_EROFS_FS_ONDEMAND enabled. The e2e tests of failover depends on private kernel patches rather upstream kernel. So we have to totally disable the failover tests for now

Github action has upgraded its worker kernel to 6.2 with
CONFIG_EROFS_FS_ONDEMAND enabled. The e2e tests of failover depends
on private kernel patches rather upstream kernel. So we have to totally
disable the failover tests for now

Signed-off-by: Changwei Ge <gechangwei@bytedance.com>
@codecov
Copy link

codecov bot commented Sep 21, 2023

Codecov Report

Merging #540 (62f53c7) into main (9a2575b) will decrease coverage by 3.99%.
Report is 18 commits behind head on main.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #540      +/-   ##
==========================================
- Coverage   37.55%   33.56%   -3.99%     
==========================================
  Files          60       65       +5     
  Lines        7139     8175    +1036     
==========================================
+ Hits         2681     2744      +63     
- Misses       4146     5116     +970     
- Partials      312      315       +3     

see 15 files with indirect coverage changes

Copy link
Member

@sctb512 sctb512 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sctb512
Copy link
Member

sctb512 commented Sep 21, 2023

Sometimes, the optimizer test also fails. It seems we should verify if the containerd is ready before generating the accessed list. I will post a PR soon for it.

@changweige changweige merged commit c0c30c7 into containerd:main Sep 22, 2023
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants