converter: fix invalid layer desc when cache hits #543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imeoer
force-pushed
the
converter-fix-cache
branch
from
29bf7b5
to
0a4ad6b
Compare
We should also add the labels.LabelUncompressed label and the label.NydusRefLayer, LayerAnnotationNydusEncryptedBlob annotations for the layer in content store cache, otherwise the generated layer descriptor is invalid for acceld/nydusify. Signed-off-by: Yan Song <yansong.ys@antgroup.com>
imeoer
force-pushed
the
converter-fix-cache
branch
from
0a4ad6b
to
30c558e
Compare
changweige
approved these changes
Oct 11, 2023
imeoer
added a commit
to imeoer/acceleration-service
that referenced
this pull request
Oct 11, 2023
Ref: containerd/nydus-snapshotter#543 Signed-off-by: Yan Song <yansong.ys@antgroup.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should also add the labels.LabelUncompressed label and the
label.NydusRefLayer, LayerAnnotationNydusEncryptedBlob annotations
for the layer in content store cache, otherwise the generated
layer descriptor is invalid for acceld/nydusify.