Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modify the nydus releases address to fix CI test #550

Merged
merged 1 commit into from
Oct 30, 2023

Conversation

billie60
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Oct 25, 2023

Codecov Report

Merging #550 (2402ede) into main (490cc94) will decrease coverage by 4.12%.
Report is 49 commits behind head on main.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #550      +/-   ##
==========================================
- Coverage   37.68%   33.56%   -4.12%     
==========================================
  Files          60       65       +5     
  Lines        7115     8176    +1061     
==========================================
+ Hits         2681     2744      +63     
- Misses       4122     5117     +995     
- Partials      312      315       +3     

see 15 files with indirect coverage changes

Copy link
Contributor

@adamqqqplay adamqqqplay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we need replace all "image-service" with "nydus" in this repository.

modify all image-service to nydus
@adamqqqplay
Copy link
Contributor

@imeoer @changweige PTAL, this PR will fix the broken CI. Thanks in advance!

Copy link
Collaborator

@imeoer imeoer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@imeoer imeoer merged commit 3ffbe8f into containerd:main Oct 30, 2023
15 of 16 checks passed
@billie60 billie60 deleted the fix-CItest branch October 31, 2023 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants