-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
misc: snapshotter: Add k3s
and rke2
overlays to the snapshotter daemonset
#577
misc: snapshotter: Add k3s
and rke2
overlays to the snapshotter daemonset
#577
Commits on Jan 31, 2024
-
misc: Move the nydus-snapshotter.yaml location
Let's have it under `base`, as we want to add a few overlays in order to make sure this will work as expected with kubernetes flavours such as `k3s`, or `rke2`. Signed-off-by: Fabiano Fidêncio <fabiano.fidencio@intel.com>
Configuration menu - View commit details
-
Copy full SHA for dbca427 - Browse repository at this point
Copy the full SHA dbca427View commit details -
misc: Adjust containerd-conf mount
In order to be able to override this accordingly to the kubernetes flavour being used, we want to make it slightly more flexible on our end and pass the directory instead of the file itself. Signed-off-by: Fabiano Fidêncio <fabiano.fidencio@intel.com>
Configuration menu - View commit details
-
Copy full SHA for 2b35b97 - Browse repository at this point
Copy the full SHA 2b35b97View commit details -
misc: Add
kubectl
to the nydus-snapshotter daemonset imageWe're doing this in order to, later on this series, use kubectl to determine which kubernetes flavour we're running on the node. Signed-off-by: Fabiano Fidêncio <fabiano.fidencio@intel.com>
Configuration menu - View commit details
-
Copy full SHA for 2f432ec - Browse repository at this point
Copy the full SHA 2f432ecView commit details
Commits on Feb 1, 2024
-
misc: Add basic function to detect the container runtime
Right now this is very basic and simply will let us know whether we're running on a node that's using containerd or not. This ended up with the move of parts of the logic on detecting containerd and containerd configuration files being removed from a few specific functions and being put directly into the main one. In the coming patches of this series we'll expand it to also detect other kubernetes flavours, such as `k3s` or `rke2`. Signed-off-by: Fabiano Fidêncio <fabiano.fidencio@intel.com>
Configuration menu - View commit details
-
Copy full SHA for 725016c - Browse repository at this point
Copy the full SHA 725016cView commit details -
With these changes we're now able to also run the nydus-snapshotter daemonset on `k3s` clusters. Signed-off-by: Fabiano Fidêncio <fabiano.fidencio@intel.com>
Configuration menu - View commit details
-
Copy full SHA for 9e6a0f1 - Browse repository at this point
Copy the full SHA 9e6a0f1View commit details -
With these changes we're now able to also run the nydus-snapshotter daemonset on `rke2` clusters. Signed-off-by: Fabiano Fidêncio <fabiano.fidencio@intel.com>
Configuration menu - View commit details
-
Copy full SHA for 451a427 - Browse repository at this point
Copy the full SHA 451a427View commit details -
misc: Detect k0s and error out if used
Differently than `k3s` or `rke2`, getting `k0s` to work as expected is quite tricky, as it relies on a drop-in configuration file, and I'm not so confident we can easily drop-in a file with all the needed bits. With this in mind, at least for now, let's just error out in case k0s is used, as at least this will make sure that the users will at least have a clue on what's been gone wrong. Signed-off-by: Fabiano Fidêncio <fabiano.fidencio@intel.com>
Configuration menu - View commit details
-
Copy full SHA for de19966 - Browse repository at this point
Copy the full SHA de19966View commit details -
tests: e2e: Adapt to using the nydus-snapshotter
Let's make sure the ClusterRole, ClusterRoleBinding, and the correct environment variables (such as NODE_NAME) are properly set as part of the E2E tests. Signed-off-by: ChengyuZhu6 <chengyu.zhu@intel.com> Signed-off-by: Fabiano Fidêncio <fabiano.fidencio@intel.com>
Configuration menu - View commit details
-
Copy full SHA for 3c70256 - Browse repository at this point
Copy the full SHA 3c70256View commit details