save digest of zfile's header/trailer and index #262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lihuiba
reviewed
Sep 11, 2023
1 task
BigVan
force-pushed
the
zfile_digest
branch
2 times, most recently
from
c00ebff
to
d51b467
Compare
BigVan
changed the title
BigVan
force-pushed
the
zfile_digest
branch
from
50798f3
to
982e02f
Compare
shuaichang
reviewed
Sep 12, 2023
| LOG_INFO("check jumptable CRC32 (` expected)", pht->index_crc); | ||
| auto crc = crc32::crc32c(ibuf.get(), index_bytes); | ||
| if (crc != pht->index_crc) { | ||
| LOG_ERRNO_RETURN(0, false, "checksum of jumptable is incorrect"); |
There was a problem hiding this comment.
nit: might just print out the expected and actual if the string is not too long?
| @@ -674,7 +706,9 @@ bool load_jump_table(IFile *file, CompressionFile::HeaderTrailer *pheader_traile | |||
| if (!pht->verify_magic() || !pht->is_header()) { | |||
| LOG_ERROR_RETURN(0, false, "header magic/type don't match"); | |||
| } | |||
|
|
|||
| if (pht->is_valid() == false) { | |||
| LOG_ERROR_RETURN(0, false, "digest verification failed."); | |||
There was a problem hiding this comment.
Just to confirm, will this trigger eviction?
There was a problem hiding this comment.
it will be evict when build_jump_table failed
yuchen0cc
reviewed
Sep 15, 2023
| @@ -745,8 +786,7 @@ IFile *zfile_open_ro(IFile *file, bool verify, bool ownership) { | |||
| auto res = file->fallocate(0, 0, -1); | |||
There was a problem hiding this comment.
if load_jump_table fails, it will evict the whole file from cache and retry @shuaichang
BigVan
force-pushed
the
zfile_digest
branch
2 times, most recently
from
749a3ae
to
9c1eb35
Compare
shuaichang
reviewed
Sep 15, 2023
Signed-off-by: Yifan Yuan <tuji.yyf@alibaba-inc.com>
BigVan
force-pushed
the
zfile_digest
branch
from
9c1eb35
to
7315c31
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Since there is unexpected behavior if incorrect data gets during the process of zfile loading, we should add a digest of header/trailer and index to make the dirty data can be evicted.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):releated issues: #253 #254 #255 #261
Please check the following list: