[EROFS] Align with the block size of overlayBD #351
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The inconsistency in the default block sizes between OverlayBD and EROFS can lead to issues during segment mapping. This patch aligns with the block size of overlaybd for mapping (i.e., OverlayBD's 512-byte size) to overcome this inconsistency. Signed-off-by: Hongzhen Luo <hongzhen@linux.alibaba.com>
hsiangkao
reviewed
Oct 22, 2024
| LSMT::RemoteMapping lba; | ||
|
|
||
| cnt = sscanf(line, "%" PRIx64" %x %" PRIx64 "%08u\n", &blkaddr, &nblocks, &toff, &zeroedlen); | ||
| if (!(cnt == 3 || cnt == 4)) |
There was a problem hiding this comment.
I think we should ignore if cnt > 4 (e.g. more hints which we don't care)
hsiangkao
reviewed
Oct 22, 2024
| cnt = sscanf(line, "%" PRIx64" %x %" PRIx64 "%08u\n", &blkaddr, &nblocks, &toff, &zeroedlen); | ||
| if (!(cnt == 3 || cnt == 4)) | ||
| LOG_ERRNO_RETURN(0, -1, "fail to read block list"); | ||
|
|
||
| lba.offset = blkaddr * blksz; | ||
| lba.count = nblocks * blksz; |
There was a problem hiding this comment.
lba.count = nblocks * blksz - round_down_blk(zeroedlen); ?
Are you sure that is round_up_blk?
hsiangkao
reviewed
Oct 22, 2024
| LSMT::RemoteMapping lba; | ||
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The inconsistency in the default block sizes between OverlayBD and EROFS can lead to issues during segment mapping. This patch aligns with the block size of overlaybd for mapping (i.e., OverlayBD's 512-byte size) to overcome this inconsistency.
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Please check the following list: