Properly handle skipped plugins in plugin get #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dims
reviewed
Oct 31, 2023
Signed-off-by: Derek McGowan <derek@mcg.dev>
dmcgowan
force-pushed
the
handle-skip-error
branch
from
c7431cc
to
fc07872
Compare
samuelkarp
approved these changes
Nov 1, 2023
henry118
approved these changes
Nov 1, 2023
AkihiroSuda
approved these changes
Nov 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Better handling of skipped plugins. Today it is only used for containerd snapshotters and the filtering is done after the get by type. When using the
InitContextinterfaces, this should be handled automatically. Currently skipped plugins could cause load errors for other plugins which get by type but do not handle the skip error.